Removed PositionsProperty #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To clarify: this function has been available in GAP since at least GAP 4.6 (the oldest version I have installed and running). I think it also was in 4.5. |
|
For the record: This function was added to QPA in April of 2011, so before 4.5. The QPA-team is happy that it now can be removed from QPA. |
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest GAP version, there is a built-in version of PositionsProperty. It is installed also installed for
IsList, and does also work on non-dense list.So there is no need to keep the function in QPA, specially since it does not work on non-dense lists and overwrites the appropriate library function.