Enhancements: Solvable permutation groups and others #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
- Coverage 57.39% 57.38% -0.01%
==========================================
Files 434 434
Lines 230693 230972 +279
==========================================
+ Hits 132403 132551 +148
- Misses 98290 98421 +131
Continue to review full report at Codecov.
|
hulpke
force-pushed
the
additions
branch
2 times, most recently
from
a30f636
to
6d53034
Compare
Also a hook for permpcgs motivated by particular generators.
So far this always used a series of subgroups -- generic code. The new code builds a permpcgs with Sims method and then uses sorted/unsorted pcgs code to translate. This should give a global speedup. Set group properties only if groups is generated by pcsequence.
Fix no perfect groups of size 1 test
also workaround for rare problem with perm conjugacy classes.
… better. Properly install maxes
Also improvements to `ReadCSV` to represent rationals as rationals.
Also fix of test file
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next iteration of keeping my changes up-to-date with master
Tick all what applies to this pull request
Write below the description of changes (for the release notes)
A bugfix in NaturalHomomorphismByIdeal for polynomial rings.
Improvements in handling solvable permutation groups.
The trivial group now is a member of the perfect groups library.
Improvements in using tabulated data for maximal subgroups.