Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command line options -U and -i #1265

Merged
merged 2 commits into from
Apr 24, 2017

Conversation

ChrisJefferson
Copy link
Contributor

The two command line options -U (set compiler options) and -i (set GAP root file) have been broken since at least 4.7.2, so let's remove them.

The reason this came to light is the way in which -U is broken causes the code coverage to wobble. The option was ignored anyway. Any use of -i would just cause GAP to not start correctly with a weird error message.

@fingolfin
Copy link
Member

For the record, these options were already broken in GAP 4.4.12, the breakage was introduced in a commit on 2002-10-23.

@fingolfin
Copy link
Member

It is somewhat sad that compiler options are going, though. Perhaps we should retain -U instead and fix it (which doesn't look too hard), possibly under a different (long) name like --compiler-args.

Then again, nobody used them... And I am so sure how useful those compiler options ever were.

@ChrisJefferson
Copy link
Contributor Author

Also, fixing --compiler-args is not just fixing the argument, even after fixing the parsing, we still ignore it anyway as we just hard-wire the options in InitKernel, and after a (very brief) investigation, if you turn all the options off the compiler produces code that doesn't even compile.

@fingolfin
Copy link
Member

Another remark: -i and -U are mentioned in the manual, in doc/ref/run.xml -- so that file needs to be modified, too.

@ChrisJefferson
Copy link
Contributor Author

Docs now fixed.

@codecov
Copy link

codecov bot commented Apr 19, 2017

Codecov Report

Merging #1265 into master will increase coverage by <.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
+ Coverage   57.19%   57.19%   +<.01%     
==========================================
  Files         923      923              
  Lines      281761   281739      -22     
  Branches    15901    15863      -38     
==========================================
- Hits       161155   161145      -10     
+ Misses     117578   117571       -7     
+ Partials     3028     3023       -5
Impacted Files Coverage Δ
src/compiler.c 61.18% <ø> (+0.12%) ⬆️
lib/system.g 66.97% <ø> (ø) ⬆️
src/gap.c 52.54% <100%> (ø) ⬆️
src/system.c 51.86% <100%> (-0.17%) ⬇️
hpcgap/src/gap.c 17.5% <33.33%> (+0.03%) ⬆️

@ChrisJefferson ChrisJefferson force-pushed the remove-dead-options branch 2 times, most recently from c7976c5 to 967005d Compare April 19, 2017 18:26
@markuspf
Copy link
Member

Needs rebase after recent merge.

I think if we ever do anything about the compiler we might feel the need for compiler options, but then the compiler should be a separate binary with its own command line options, anyway.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still am happy with this. So far no complaints in reaction to @ChrisJefferson's mail on the removal. So I think @markuspf can merge this whenever he wants, if he agrees with the premise of the PR (which I assume he does).

Pr( "gap: hmm, I cannot find '%s' maybe",
(Int)SySystemInitFile, 0L );
Pr( "gap: hmm, I cannot find 'lib/init.g' maybe",
0L, 0L );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: this Pr call could now b fused with the following one.

@markuspf markuspf merged commit aefb200 into gap-system:master Apr 24, 2017
@ChrisJefferson ChrisJefferson deleted the remove-dead-options branch May 12, 2017 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants