-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove command line options -U
and -i
#1265
Remove command line options -U
and -i
#1265
Conversation
6898f3b
to
7bdff80
Compare
For the record, these options were already broken in GAP 4.4.12, the breakage was introduced in a commit on 2002-10-23. |
It is somewhat sad that compiler options are going, though. Perhaps we should retain Then again, nobody used them... And I am so sure how useful those compiler options ever were. |
Also, fixing |
Another remark: |
7bdff80
to
2cac320
Compare
Docs now fixed. |
Codecov Report
@@ Coverage Diff @@
## master #1265 +/- ##
==========================================
+ Coverage 57.19% 57.19% +<.01%
==========================================
Files 923 923
Lines 281761 281739 -22
Branches 15901 15863 -38
==========================================
- Hits 161155 161145 -10
+ Misses 117578 117571 -7
+ Partials 3028 3023 -5
|
c7976c5
to
967005d
Compare
Needs rebase after recent merge. I think if we ever do anything about the compiler we might feel the need for compiler options, but then the compiler should be a separate binary with its own command line options, anyway. |
967005d
to
0f3167b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still am happy with this. So far no complaints in reaction to @ChrisJefferson's mail on the removal. So I think @markuspf can merge this whenever he wants, if he agrees with the premise of the PR (which I assume he does).
Pr( "gap: hmm, I cannot find '%s' maybe", | ||
(Int)SySystemInitFile, 0L ); | ||
Pr( "gap: hmm, I cannot find 'lib/init.g' maybe", | ||
0L, 0L ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: this Pr
call could now b fused with the following one.
The two command line options
-U
(set compiler options) and-i
(set GAP root file) have been broken since at least 4.7.2, so let's remove them.The reason this came to light is the way in which
-U
is broken causes the code coverage to wobble. The option was ignored anyway. Any use of-i
would just cause GAP to not start correctly with a weird error message.