New 'AlgebraicExtensionNC' operation. #1665
Conversation
- provides a variant of 'AlgebraicExtension' that does not check the input polynomial for irreducibility - documents the new operation - also document the optional argument of a string for printing the generator of the extension - added a test file
| [IsField,IsUnivariatePolynomial],0,DoAlgebraicExt); | ||
| [IsField,IsUnivariatePolynomial],0, | ||
| function(k,f) return DoAlgebraicExt(k,f,true); | ||
| end); |
There was a problem hiding this comment.
You could use {k,f} -> DoAlgebraicExt(k,f,true) here, which is slightly more concise.
There was a problem hiding this comment.
I'm aware of this new syntax. But I prefer to have code which is also readable with older GAP versions which I'm still using.
| InstallMethod(AlgebraicExtensionNC,"generic",true, | ||
| [IsField,IsUnivariatePolynomial],0, | ||
| function(k,f) return DoAlgebraicExt(k,f,false); | ||
| end); |
| [IsField,IsUnivariatePolynomial,IsString],0, | ||
| function(k,f,nam) return DoAlgebraicExt(k,f,nam,true); | ||
| end); | ||
|
|
There was a problem hiding this comment.
{k,f,nam} -> DoAlgebraicExt(k,f,nam,true)
|
|
||
| RedispatchOnCondition(AlgebraicExtension,true,[IsField,IsRationalFunction], | ||
| [IsField,IsUnivariatePolynomial],0); | ||
|
|
||
| RedispatchOnCondition(AlgebraicExtensionNC,true,[IsField,IsRationalFunction], | ||
| [IsField,IsUnivariatePolynomial],0); | ||
|
|
There was a problem hiding this comment.
Could you format this in the same way as below?
There was a problem hiding this comment.
I don't know what you mean here. I have just copied the existing lines and added the NC.
There was a problem hiding this comment.
I mean I like it better if it's formatted like this for reasons of line lengths (as it is done in lines 243 ff for AlgebraicExtension(NC))
RedispatchOnCondition(AlgebraicExtensionNC,true,
[IsField,IsRationalFunction],
[IsField,IsUnivariatePolynomial],0);
olexandr-konovalov
added
the
gapdays2017-fall
olexandr-konovalov
added
the
release notes: added
the input polynomial for irreducibility
generator of the extension