Make line editing resilient to LineEditKeyHandler failure #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, if the LineEditKeyHandler returns nothing (e.g. due to an Error()), or if it returns something that isn't a list, or a list of the wrong size, then just ignore this, instead of running into segfaults. This addresses one part of issue gap-system#1853 Also remove superfluous "else {" and "}" when HAVE_LIBREADLINE is set.
fingolfin
added
the
kind: bug: crash
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
+ Coverage 63.12% 63.13% +<.01%
==========================================
Files 967 967
Lines 290318 290318
Branches 12746 12722 -24
==========================================
+ Hits 183269 183279 +10
+ Misses 104248 104241 -7
+ Partials 2801 2798 -3
|
ChrisJefferson
approved these changes
Nov 6, 2017
fingolfin
added
release notes: not needed
olexandr-konovalov
added
the
release notes: added
fingolfin
added
the
kind: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, if the LineEditKeyHandler returns nothing (e.g. due to an
Error()), or if it returns something that isn't a list, or a list of the wrong
size, then just ignore this, instead of running into segfaults.
This addresses one part of issue #1853
Also remove superfluous "else {" and "}" when HAVE_LIBREADLINE is set.