-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix QuotientMod docs, and the integer implementation #1991
Fix QuotientMod docs, and the integer implementation #1991
Conversation
d7df511
to
4c0d7f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1991 +/- ##
==========================================
+ Coverage 65.94% 65.95% +<.01%
==========================================
Files 898 898
Lines 273206 273679 +473
Branches 12771 11949 -822
==========================================
+ Hits 180175 180513 +338
- Misses 90211 90312 +101
- Partials 2820 2854 +34
|
4c0d7f3
to
9fa2e77
Compare
@alex-konovalov this is reverting resp. adjusting some changes you made back then, so perhaps you have some thoughts on this? |
For example, what's changed:
Shouldn't both cases in the 2nd example return a non- Otherwise, I ran GAP test suite in Jenkins for this PR, and did not discover any regressions. |
9fa2e77
to
afaa0f6
Compare
@alex-konovalov you are 100% right, I am glad you paid attention and double checked! In fact, also the result for All of this should be resolved now. Also, I changed the code to use |
This partially reverts changes we made 2013. The documentation is now correct (resp. consistent again), and several corner cases work correctly. E.g. QuotientMod(0,0,m) never worked correctly, even though by the definition given in the manual, it should return 0. Fixes gap-system#149
afaa0f6
to
409b79e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fingolfin - now looks good, and I've rerun Jenkins test to see if it has any impact on package tests - apparently none.
Excellent, thank you both very much. |
This partially reverts changes we made 2013. The documentation
is now correct (resp. consistent again), and several corner cases
work correctly. E.g. QuotientMod(0,0,m) never worked correctly, even
though by the definition given in the manual, 1 is a valid result.
Fixes #149