Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in ValueMolienSeries #2183

Merged
merged 3 commits into from
Feb 16, 2018
Merged

Fix bug in ValueMolienSeries #2183

merged 3 commits into from
Feb 16, 2018

Conversation

fingolfin
Copy link
Member

Fixes #300

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them labels Feb 15, 2018
ThomasBreuer
ThomasBreuer requested changes Feb 15, 2018
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is correct.
Additionally, the record component pol should be set in the result of the function MolienSeriesWithGivenDenominator.

@fingolfin
Copy link
Member Author

Fixed MolienSeriesWithGivenDenominator and add tests that verify this explicitly.

@ChrisJefferson ChrisJefferson merged commit 0be7c3d into gap-system:master Feb 16, 2018
@fingolfin fingolfin deleted the mh/ValueMolienSeries branch February 16, 2018 11:06
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

@dimpase dimpase Awaiting requested review from dimpase

Assignees
No one assigned
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fingolfin @ThomasBreuer @ChrisJefferson