Handle spaces in filenames of gziped filenames #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap filenames we pass to gzip/gunzip via shell in single quotes, so we handle spaces and some other characters which need escaping. This does not handle all possible filenames which could cause a problem, but hopefully covers most which will arise in practice.
Codecov Report
@@ Coverage Diff @@
## master #2268 +/- ##
==========================================
- Coverage 70.57% 70.57% -0.01%
==========================================
Files 481 481
Lines 253237 253239 +2
==========================================
Hits 178728 178728
- Misses 74509 74511 +2
|
fingolfin
approved these changes
Mar 20, 2018
|
I took the liberty of adding "Resolves #2264" to your PR description, so that merging this PR will close the associated issue. |
fingolfin
added
the
kind: enhancement
|
Would this be a good candidate to backport for gap 4.9.2? It seems unlikely to do much harm. |
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap filenames we pass to gzip/gunzip via shell in single quotes,
so we handle spaces and some other characters which need escaping.
This does not handle all possible filenames which could cause a
problem, but hopefully covers most which will arise in practice.
Resolves #2264