Improve valgrind support #2718
Merged
Improve valgrind support #2718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
added
topic: kernel
release notes: to be added
fingolfin
reviewed
Aug 20, 2018
src/gasman.c
Outdated
| */ | ||
|
|
||
| Bag * NewWeakDeadBagMarker = (Bag *)(1000*sizeof(Bag) + 1L); | ||
| Bag * OldWeakDeadBagMarker = (Bag *)(1001*sizeof(Bag) + 1L); |
There was a problem hiding this comment.
I need to refer to it in an earlier place in the file
There was a problem hiding this comment.
But turns out I didn't end up using that. Taken this part of the PR out.
src/gasman.c
Outdated
| Int bufsize = (Int)EndBags - (Int)AllocBags; | ||
| return bufsize < 4096 ? bufsize : 4096; | ||
| VALGRIND_MAKE_MEM_DEFINED(bag, sizeof(Bag)); | ||
| char* ptr = (char*)PTR_BAG(bag); |
There was a problem hiding this comment.
All formatted
src/gasman.c
Outdated
| @@ -2043,7 +2094,7 @@ UInt CollectBags ( | |||
| /* free the identifier */ | |||
| *(Bag*)(header->link) = FreeMptrBags; | |||
| FreeMptrBags = header->link; | |||
|
|
|||
There was a problem hiding this comment.
Still is in the diff? But anyway, not important
ChrisJefferson
force-pushed
the
valgrind
branch
2 times, most recently
from
df9b4fc
to
632b5f1
Compare
fingolfin
reviewed
Aug 20, 2018
src/gasman.c
Outdated
| @@ -202,11 +202,23 @@ enum { | |||
| }; | |||
|
|
|||
|
|
|||
| static inline UInt WORDS_BAG(UInt size) | |||
| // BAG_SLACK is used to define a block of empty space at the end of each | |||
| // bag, which can then be marked as "not accessable" in the memory checker | |||
There was a problem hiding this comment.
Typo: accessable -> accessible?
fingolfin
approved these changes
Aug 20, 2018
src/gasman.c
Outdated
| @@ -2043,7 +2094,7 @@ UInt CollectBags ( | |||
| /* free the identifier */ | |||
| *(Bag*)(header->link) = FreeMptrBags; | |||
| FreeMptrBags = header->link; | |||
|
|
|||
There was a problem hiding this comment.
Still is in the diff? But anyway, not important
ChrisJefferson
force-pushed
the
valgrind
branch
from
632b5f1
to
77f4dce
Compare
Codecov Report
@@ Coverage Diff @@
## master #2718 +/- ##
==========================================
+ Coverage 75.75% 75.75% +<.01%
==========================================
Files 478 478
Lines 241495 241576 +81
==========================================
+ Hits 182938 183005 +67
- Misses 58557 58571 +14
|
|
There is now a merge commit by @markuspf in here. Perhaps @ChrisJefferson can rebase the PR once again to get rid of that? |
ChrisJefferson
force-pushed
the
valgrind
branch
from
281c177
to
b47d368
Compare
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch greatly improves --enable-valgrind. This puts padding before and after every Bag, so we can detect invalid reads or writes off the beginning and end of every Bag