Remove ward from the build system, some CI tweaks #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: HPC-GAP
fingolfin
commented
Sep 25, 2018
.appveyor.yml
Outdated
| # HPCGAP: yes | ||
| - CYG_ARCH: x86_64 | ||
| CYG_ROOT: C:\cygwin64 | ||
| HPCGAP: yes |
There was a problem hiding this comment.
I am not sure enabling HPC-GAP builds for Windows is worth it at this stage, but I wanted to try what happens; I might remove this again in the final version of this PR.
fingolfin
commented
Sep 25, 2018
.appveyor.yml
Outdated
| # HPCGAP: yes | ||
| - CYG_ARCH: x86_64 | ||
| CYG_ROOT: C:\cygwin64 | ||
| HPCGAP: yes | ||
| # BUILDDIR: build # HPC-GAP only supports kernel extensions for of out-of-tree builds |
There was a problem hiding this comment.
I am really confused by the above BUILDDIR line and the comment... so I left it commented out to see what happens
This was referenced Sep 25, 2018
fingolfin
force-pushed
the
mh/no-ward
branch
2 times, most recently
from
971b324
to
7f242bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #2870 +/- ##
==========================================
+ Coverage 83.38% 83.72% +0.34%
==========================================
Files 636 687 +51
Lines 323991 352228 +28237
==========================================
+ Hits 270167 294915 +24748
- Misses 53824 57313 +3489
|
It is not doing anything anymore, see issue gap-system#1742
fingolfin
force-pushed
the
mh/no-ward
branch
from
7f242bf
to
e65f218
Compare
rbehrends
approved these changes
Sep 27, 2018
ChrisJefferson
approved these changes
Sep 27, 2018
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.