Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IsomorphismTransformationSemigroup return IdentityMapping for a transformation semigroup #2876

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Make IsomorphismTransformationSemigroup return IdentityMapping for a transformation semigroup #2876

merged 1 commit into from
Sep 28, 2018

Conversation

wilfwilson
Copy link
Member

I think it is appropriate that IsomorphismTransformationSemigroup for a transformation semigroup should simply return the IdentityMapping, and indeed this should always be the case, and so I've increased the rank by SUM_FLAGS. This is analogous to the situation for perm groups:

gap/lib/ghomperm.gi

Lines 1928 to 1933 in d0fb0f5

InstallMethod( IsomorphismPermGroup,
"perm groups",
true,
[ IsPermGroup ],
SUM_FLAGS,
IdentityMapping );

hulpke
hulpke approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@hulpke hulpke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine.

@markuspf markuspf merged commit 44895f9 into gap-system:master Sep 28, 2018
@wilfwilson wilfwilson deleted the semitrans branch November 24, 2018 21:51
@PaulaHaehndel PaulaHaehndel added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Apr 15, 2019
@wilfwilson wilfwilson added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Apr 24, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuspf markuspf markuspf left review comments

@fingolfin fingolfin fingolfin approved these changes

@hulpke hulpke hulpke approved these changes

Assignees
No one assigned
Labels
release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Milestone
GAP 4.11.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wilfwilson @fingolfin @markuspf @hulpke @olexandr-konovalov @PaulaHaehndel