Update Julia setup in buildsys, and test Julia GC integration on Travis #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: tests
fingolfin
force-pushed
the
mh/julia-travis
branch
from
ff1408a
to
49240e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #2905 +/- ##
==========================================
+ Coverage 83.74% 83.75% +<.01%
==========================================
Files 680 681 +1
Lines 346265 346552 +287
==========================================
+ Hits 289971 290244 +273
- Misses 56294 56308 +14
|
fingolfin
force-pushed
the
mh/julia-travis
branch
4 times, most recently
from
bfc22ee
to
93d371d
Compare
fingolfin
changed the title
fingolfin
added
topic: build system
backport-to-4.9
and removed
do not merge
sebasguts
approved these changes
Oct 9, 2018
Now configure only checks for a julia binary; then we use julia-config.jl to determine all relevant paths, and do it all from inside Makefile.rules. The downside of this is that if we find a broken Julia, this won't work, but configure won't tell us. The upside is that we get all the correct compiler and linker flags. In particular, we don't have to hardcode `#define JULIA_ENABLE_THREADING` anymore.
fingolfin
force-pushed
the
mh/julia-travis
branch
from
93d371d
to
e3954d7
Compare
fingolfin
force-pushed
the
mh/julia-travis
branch
from
e3954d7
to
269d490
Compare
fingolfin
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Julia GC extension code has now been merged into Julia master, meaning that it is available in Julia nightly builds (and also should be in Julia 1.1, once that gets released).
This now makes it possible to add a Travis job which tests the Julia GC integration in GAP.
Moreover, the Julia integration int the build system was rewritten to make use of
julia-config.jlto obtain the correct compiler & linker flags.