kernel: when using julia_gc, call jl_atexit_hook in SyExit #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
|
The changes to Panic/SyExit are sensible and good. One random question -- why doesn't julia_gc just pass jl_atexit_hook to atexit? |
sebasguts
requested changes
Oct 18, 2018
src/saveload.c
Outdated
| @@ -374,8 +374,7 @@ static void LoadBagData ( void ) | |||
|
|
|||
| if (TNAM_TNUM(type) == NULL) | |||
| { | |||
| Pr("Bad type %d, size %d\n",type,size); | |||
| exit(1); | |||
| Panic("Bad type %d, size %d\n",type,size); | |||
There was a problem hiding this comment.
The compiler seems to complain about the %d
|
@ChrisJefferson fair question, I also wondered. One thing is that |
fingolfin
force-pushed
the
mh/jl_atexit_hook
branch
from
7674fed
to
9ab46d8
Compare
|
Wanting the exit code is a good enough reason, in that case I'm happy to merge it (it's not going to effect GAP without Julia anyway of course) |
sebasguts
approved these changes
Oct 19, 2018
|
Backported via 19aafe0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as recommended by https://docs.julialang.org/en/v1/manual/embedding/index.html
This makes it possible to collect coverage data in Julia code (as that is written to disk via that atexit hook).