Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildsys: disable 'make install', as people keep ignoring the warning #3005

Merged
merged 1 commit into from
Nov 15, 2018
Merged

buildsys: disable 'make install', as people keep ignoring the warning #3005

merged 1 commit into from
Nov 15, 2018

Conversation

fingolfin
Copy link
Member

This should be backported to GAP 4.10.

@fingolfin fingolfin added topic: build system release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes backport-to-4.10 labels Nov 15, 2018
@fingolfin fingolfin changed the title buildsys: disable , as people keep ignoring the warning buildsys: disable make install, as people keep ignoring the warning Nov 15, 2018
@fingolfin fingolfin changed the title buildsys: disable make install, as people keep ignoring the warning buildsys: disable 'make install', as people keep ignoring the warning Nov 15, 2018
@codecov
Copy link

codecov bot commented Nov 15, 2018 •
edited
Loading

Codecov Report

Merging #3005 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3005      +/-   ##
==========================================
- Coverage   85.13%   85.12%   -0.01%     
==========================================
  Files         110      110              
  Lines       56960    56960              
==========================================
- Hits        48491    48489       -2     
- Misses       8469     8471       +2
Impacted Files Coverage Δ
src/iostream.c 62.35% <0%> (-1.15%) ⬇️
src/stats.c 95.07% <0%> (-0.21%) ⬇️
src/hpc/threadapi.c 45.19% <0%> (+0.17%) ⬆️

@markuspf markuspf merged commit 705cd1a into gap-system:master Nov 15, 2018
@fingolfin fingolfin deleted the mh/no-make-install branch November 15, 2018 11:13
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.10.1 milestone Nov 24, 2018
@olexandr-konovalov
Copy link
Member

Backported to stable-4.10 in 62cf084

@olexandr-konovalov olexandr-konovalov added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 23, 2019
@jdemeyer
Copy link

What's the rationale for disabling install-headers? We were using that in Sage for GAP-4.10.0 without problems. What is the new recommended way to install GAP headers?

@jdemeyer
Copy link

Same for install-libgap.

@jdemeyer
Copy link

I just saw that #3294 reverts this, so I guess it makes sense for Sage to use that patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@markuspf markuspf markuspf approved these changes

Assignees
No one assigned
Labels
backport-to-4.10-DONE release notes: added PRs introducing changes that have since been mentioned in the release notes topic: build system
Projects
None yet
Milestone
GAP 4.10.1
Development

Successfully merging this pull request may close these issues.
5 participants
@fingolfin @olexandr-konovalov @jdemeyer @ChrisJefferson @markuspf