-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle \r without a \n in cygwin #3320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3320 +/- ##
==========================================
- Coverage 85.26% 85.25% -0.01%
==========================================
Files 697 698 +1
Lines 344153 344158 +5
==========================================
- Hits 293426 293416 -10
- Misses 50727 50742 +15
|
I triggered a build of this PR on Jenkins here (St Andrews access only) |
fingolfin
approved these changes
Mar 8, 2019
fingolfin
added
os: windows
Issues and PRs that are (at least partially) specific to Windows
topic: kernel
release notes: to be added
PRs introducing changes that should be (but have not yet been) mentioned in the release notes
labels
Mar 8, 2019
@alex-konovalov What was the result of your Jenkins build? (I don't have access). |
@ChrisJefferson this has to be rebased to include #3326, otherwise Windows test terminates early. |
fingolfin
added
the
kind: bug
Issues describing general bugs, and PRs fixing them
label
Mar 19, 2019
DominikBernhardt
added
release notes: added
PRs introducing changes that have since been mentioned in the release notes
and removed
release notes: to be added
PRs introducing changes that should be (but have not yet been) mentioned in the release notes
labels
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: bug
Issues describing general bugs, and PRs fixing them
os: windows
Issues and PRs that are (at least partially) specific to Windows
release notes: added
PRs introducing changes that have since been mentioned in the release notes
topic: kernel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem whereby if GAP on windows sees a \r, it will remove the next \n, no matter how far away it is.
This isn't tested, because I found it very hard to come up with a sensible test, as git (or other tools) can try to "clean up" line endings. Hopefully the PR is clean enough.
In practice, there turns out to be a whole bunch of things that could be "improved" around here, but I don't really want to rewrite lots of the file handling. This fixes a single, immediate, problem.