-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from 2GB memory space to 3/4 of physical memory #3483
Switch from 2GB memory space to 3/4 of physical memory #3483
Conversation
4e14cfe
to
bc0d327
Compare
Codecov Report
@@ Coverage Diff @@
## master #3483 +/- ##
==========================================
- Coverage 85.43% 85.37% -0.07%
==========================================
Files 699 698 -1
Lines 346759 344604 -2155
==========================================
- Hits 296253 294204 -2049
+ Misses 50506 50400 -106
|
This is required to let GAP dynamically calculate these values, based on the user's physical memory
bc0d327
to
4294453
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would be a good idea to document (perhaps with the command line option for -o
) what the defaults are? Not a requirement.
4294453
to
2c9e676
Compare
2c9e676
to
cf43990
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is fantastic to be able to get the available memory -- in fact I would love in the library to have the abilikty to poll the available memory to check wehther certain calculations are possible.
Setting the default to 3/4 available memoryt could be an issue on multi-user systems (and that was the initial reason for setting a limit): A careless beginner can easily start allocating enormous amounts of memory, by asking for the elements of S_50 or so. How about maintaining a safety level at what would be above a single-user system, but could be on a multi-user server -- somewhere around 16GB?
The current 2GB memory limit was set in 2012, and memory has grown since then.
On 64-bit OSes, this switches to a default of 3/4 of physical memory, or 2GB, whichever is larger. 32-bit OSes are left at their previous 1GB (just because I don't want to think about issues of filling up the memory space on 32-bit OSes, and most people won't be using them any more).
Tested on linux, mac and cygwin.
For release notes: