Fix a "method not found" error in SubdirectProduct
#3485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, verify that bug gap-system#3431 is fixed
The generic SubdirectProductOp performs "recursion". But SubdirectProductOp in general expects the mappings given to it be group homomorphisms, and also that they "know" about this. Since it sometimes happens that mappings are produced that do not "know" this information, explicitly check for this (just as `SubdirectProduct` does). Fixes gap-system#3431 "even more"
fingolfin
added
kind: bug
hulpke
approved these changes
Jun 4, 2019
wilfwilson
approved these changes
Jun 5, 2019
There was a problem hiding this comment.
I'm happy for this to be merged. It's less clear to me that #3437 should be closed when this is merged (Of course #3437 would need to be updated, but perhaps @stevelinton would still like the remaining changes in his PR to be merged in due course).
7 tasks
olexandr-konovalov
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to PR #3437, with a less invasive change, which IMHO makes it more appropriate for backporting to GAP 4.10. The remaining changes in PR #3437 could of course still be added to GAP 4.11, although I remain somewhat sceptical about that.
Fixes #3431