Fix bug in MaximalSubgroupClassReps that could lead to a wrong result
#3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code used to compute a special pcgs in a pc group image and transfer some cached information -- that does not seem to work properly, and also not be worth the effort of doing. Replace by direct computation.
hulpke
added
kind: bug: wrong result
fingolfin
approved these changes
Sep 18, 2019
wilfwilson
approved these changes
Sep 18, 2019
fingolfin
pushed a commit
that referenced
this pull request
Sep 20, 2019
The code used to compute a special pcgs in a pc group image and transfer some cached information -- that does not seem to work properly, and also not be worth the effort of doing. Replace by direct computation.
|
Backported to stable-4.11 in commit a0b9798 |
fingolfin
changed the title
MaximalSubgroupClassReps that could lead to a wrong result
fingolfin
changed the title
MaximalSubgroupClassReps that could lead to a wrong resultMaximalSubgroupClassReps that could lead to a wrong result
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code used to compute a special pcgs in a pc group image and transfer
some cached information -- that does not seem to work properly, and also not
be worth the effort of doing. Replace by direct computation.
This fixes a bug reported by Andries Brouwer (example is in test file)
Text for release notes
A bug in
MaximalSubgroupClassRepsthat could lead to a wrong result was fixed.