Allow package build systems to detect GAP version by inserting GAP_VERSION into sysinfo.gap
#3746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful for package build systems which want to verify the GAP version.
fingolfin
added
kind: enhancement
ChrisJefferson
approved these changes
Nov 18, 2019
olexandr-konovalov
approved these changes
Nov 18, 2019
|
Backported to stable-4.11 as f1f5dc5 |
fingolfin
changed the title
GAP_VERSION into sysinfo.gap
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for package build systems which want to verify the GAP version. If
GAP_VERSIONis missing, then the package knows it is dealing with GAP <= 4.10.xThis is a minor change but potentially quite useful for packages, yet clearly won't interfere with anything badly, so I'd really like to backport it. At the same time, it is relevant for package authors, so I'd like to mention it in the release notes, together with other stuff relevant for package authors.