Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admit CentralIdempotentsOfAlgebra for algebras without One #3920

Merged
merged 2 commits into from
Mar 22, 2020
Merged

Admit CentralIdempotentsOfAlgebra for algebras without One #3920

merged 2 commits into from
Mar 22, 2020

Conversation

ThomasBreuer
Copy link
Contributor

Description

Up to now, the GAP library method for CentralIdempotentsOfAlgebra
requires only IsAlgebra but the method throws an error if the argument
does not support One.
In fact, only MultiplicativeNeutralElement is needed.
Klaus Lux has observed the deficiency.

(For a meaningful test example, I have also added Representative methods for left/right/two sided ideals with known ideal generators. No such method had been available up to now.)

Text for release notes

Admit CentralIdempotentsOfAlgebra for algebras without One.

@ThomasBreuer
generalize setup for CentralIdempotentsOfAlgebra
7298062 
Up to now, the GAP library method for `CentralIdempotentsOfAlgebra`
requires only `IsAlgebra` but the method throws an error if the argument
does not support `One`.
In fact, only `MultiplicativeNeutralElement` is needed.
@ThomasBreuer
added missing Representative methods for ideals
58d63a2
@ThomasBreuer ThomasBreuer added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Mar 22, 2020
@coveralls
Copy link

coveralls commented Mar 22, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 84.296% when pulling 58d63a2 on ThomasBreuer:TB_CentralIdempotentsOfAlgebra into 05347eb on gap-system:master.

@fingolfin fingolfin merged commit 651c269 into gap-system:master Mar 22, 2020
@ThomasBreuer ThomasBreuer deleted the TB_CentralIdempotentsOfAlgebra branch March 23, 2020 13:26
@danielrademacher danielrademacher self-assigned this Feb 16, 2021
@danielrademacher danielrademacher changed the title generalize setup for CentralIdempotentsOfAlgebra Admit 'CentralIdempotentsOfAlgebra' for algebras without 'One' Feb 16, 2021
@danielrademacher danielrademacher removed their assignment Feb 16, 2021
@danielrademacher danielrademacher added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 16, 2021
@olexandr-konovalov olexandr-konovalov mentioned this pull request Feb 19, 2021
Closed
@olexandr-konovalov olexandr-konovalov mentioned this pull request Mar 23, 2021
Merged
@fingolfin fingolfin changed the title Admit 'CentralIdempotentsOfAlgebra' for algebras without 'One' Admit CentralIdempotentsOfAlgebra for algebras without One Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomasBreuer @coveralls @fingolfin @danielrademacher