Fix potential garbage collector crashes on 64bit ARM systems #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make the tests for attributes potentially independent from config (for a future where we don't want to include config.h from header files anymore)
Inlining this function can break the garbage collector. This was the case on Linux aarch64. Thanks to Jerry James (Fedora) and Bill Allombert (Debian) for help tracking this down. Fixes gap-system#3919
fingolfin
added
kind: bug
Closed
|
If we aren't immediately going to make a release, I'd like to wait a couple of days as I just got my hands on a raspberry pi, so I'll sanity check this (but it certainly seems right, and I'm very glad it was found and reported). |
|
@ChrisJefferson sure, no need for undue haste. I am also hoping that PR #3966 will exhibit this crash and then we can modify that PR by merging this PR in temporarily to see if it helps. |
|
For the backport, see #3966 |
|
I've checked this, and agree it looks right. |
ChrisJefferson
approved these changes
Apr 20, 2020
ThomasBreuer
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Jerry James @jamesjer (Fedora) and Bill Allombert (Debian) for help tracking this down.
Fixes #3919
For the backport, only the second commit is needed.