Add ARCH_IS_WSL to detect Windows Subsystem for Linux
#4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
added
kind: enhancement
fingolfin
reviewed
Feb 15, 2021
wilfwilson
approved these changes
Feb 16, 2021
|
Just wondering, how is this related to PR #3939? |
|
This is unrelated to cygwin changes (although in the long term, the plan is the two distros will come closer together. This will be one place where they differ, as they have different ways of spawning files in windows) |
fingolfin
approved these changes
Feb 17, 2021
ChrisJefferson
force-pushed
the
arch_is_wsl
branch
from
7729843
to
b558690
Compare
Codecov Report
@@ Coverage Diff @@
## master #4249 +/- ##
==========================================
- Coverage 82.26% 81.90% -0.36%
==========================================
Files 686 682 -4
Lines 296672 294708 -1964
==========================================
- Hits 244045 241393 -2652
- Misses 52627 53315 +688
|
|
Hopefully all cleaned up now. I decided not to fix other true, I thought they could be sweeped (also false) in another PR. |
|
Sure, thanks Chris. I'll merge this when the tests pass. |
wilfwilson
added
the
gapdays2021-spring
fingolfin
added
release notes: use title
fingolfin
changed the title
ARCH_IS_WSL to detect Windows Subsystem for Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us detect the "Windows Subsystem for Linux".
I realise in some ways the naming has gotten weird now, we call Cygwin (one linux in windows) "ARCH_IS_WINDOWS", which WSL is not. While that is weird, I think it makes sense, WSL is a complete install of Linux (usually Ubuntu).
The only time we need ARCH_IS_WSL is when we want to open GUI programs -- I've added help viewers (unfortunately it doesn't seem possible to open either anchors in HTML, which makes this much less useful. I spent some time searching the internet, but everything people say seems to not work in practice, except making a new webpage which just forwards to the anchor, and I didn't want to do that as it would create lots of new temp files/directories).
I plan on using this in the 'profiling' package too, to automatically open HTML pages (I originally wrote this in that package, then thought I might be generally useful).