-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another ViewString method for inverse semigroups #438
Add another ViewString method for inverse semigroups #438
Conversation
0acf9b9
to
e96c958
Compare
[IsInverseSemigroup and HasGeneratorsOfSemigroup], | ||
_ViewStringForSemigroups); | ||
|
||
InstallMethod(ViewString, "for an inverse semigroup with generators", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method has the same info string as the previous one - could we make it more unique?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Houw about "with semigroup generators" and "with inverse semigroup generators"
@james-d-mitchell thanks - looks fine to me except one remark. When ready, I suggest to merge this into the master branch to see if it breaks any tests for GAP packages. If this change will be not disruptive, it could go into stable-4.8 branch too. |
This commit introduces a method for ViewString for semigroups satisfying IsInverseSemigroup and HasGeneratorsOfSemigroup. The rank of the filter IsSemigroup and HasGeneratorsOfSemigroup is 14, whereas the rank of IsInverseSemigroup is 21. Previously, if a semigroup learned that it was inverse but did not have GeneratorsOfInverseSemigroup, then the default ViewString method for IsInverseSemigroup was used. With this commit the more elaborate _ViewStringForSemigroups is used instead.
e96c958
to
f56c5e3
Compare
@alex-konovalov and @fingolfin, good suggestions! I've made the changes. |
@james-d-mitchell thanks - looks good to me, I will merge this now. I can't find @fingolfin's comment - apparently it was made on a commit and now gone because of the forced push, but I've looked for it in my email archive to check. |
…oups Add another ViewString method for inverse semigroups
This commit introduces a method for
ViewString
for semigroups satisfyingIsInverseSemigroup and HasGeneratorsOfSemigroup
. The rank of the filterIsSemigroup and HasGeneratorsOfSemigroup
is 14, whereas the rank ofIsInverseSemigroup
is 21. Previously, if a semigroup learned that it wasinverse but did not have
GeneratorsOfInverseSemigroup
, then the defaultViewString
method forIsInverseSemigroup
was used. With this commit themore elaborate
_ViewStringForSemigroups
is used instead.For example, before the change:
After the change: