Rename USER_HOME_EXPAND to UserHomeExpand and add documentation #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisJefferson
force-pushed
the
userhomeexpand
branch
from
93d76e6
to
36a84fb
Compare
olexandr-konovalov
added
the
gapsagedays2016
|
I think you nean UserHome rather than UserName (and USER_HOME rather than USER_NAME) in the comment above. |
stevelinton
added a commit
that referenced
this pull request
Jan 14, 2016
Rename USER_HOME_EXPAND to UserHomeExpand and add documentation
|
It is sensible to document this function as I have just sent another pull request #456 with a further iteration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
USER_HOME_EXPANDexpands an initial~in a filename to the user's home directory. It is used in several places and it seems worth promoting to a documented function.USER_NAME_EXPANDis left, because we need this function very early during startup, in particular before functions likeErrorexist, so we haveUserNameExpandwith nice input checking which callsUSER_NAME_EXPAND.