introduce IsMatrixOrMatrixObj
#4518
Conversation
as sketched in issue gap-system#4503. In this first step, I have changed the documentation of the defining filters and replaced `IsMatrixObj` by `IsMatrixOrMatrixObj` in most places. (In a next step, we can now change the method installations mentioned in issue gap-system#4503.)
ThomasBreuer
added
kind: enhancement
|
|
lib/matobj1.gd
Outdated
| ## <Filt Name="IsMatrixOrMatrixObj" Arg='obj' Type="category"/> | ||
| ## | ||
| ## <Description> | ||
| ## This filter is the <Q>common roof</Q> for <Ref Filt="IsMatrix"/> and |
There was a problem hiding this comment.
I am not sure if "common roof" will be understood ? Perhaps we could borrow from the IsListOrCollection documentation, which starts like this:
Several functions are defined for both lists and collections, [...]
IsListOrCollection is a supercategory of IsList and IsCollection (that is, all lists and collections lie in this category)
... also in `libgap-api`. If we take the filters `IsMatrixOrMatrixObj`, `IsMatrix`, `IsMatrixObj` seriously then their meaning must be reflected also in the libgap interface. (Currently `IsMatrix` is not exposed in the interface, perhaps it should be added now?) Currently there is no positive test for `IsMatrixObj` in `tst/testlibgap/api.c`.
as suggested by @fingolfin. Note that this formulation still appears in `lib/word.gd`, see `?IsWord`.
There was a problem hiding this comment.
There are obvious things to do next (like changing a bunch of methods back to IsMatrixObj and simplifying their code), but I don't think we need to wait for this. From my POV this can be merged right away.
@ThomasBreuer if you agree, let's do it, and let's continue work afterwards.
as sketched in issue #4503.
In this first step, I have changed the documentation of the defining filters and replaced
IsMatrixObjbyIsMatrixOrMatrixObjin most places.(In a next step, we can now change the method installations mentioned in issue #4503.)