matrixobj: deal with mutability questions #5254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed the mutability definition for vector and matrix objects:
- The `ConstructingFilter` value indicates whether mutable variants
are possible at all, as follows:
If the filter implies `IsCopyable` then one can create mutable variants,
otherwise not.
- In the definitions of `NewVector`, `ZeroVector`, `NewMatrix`, `ZeroMatrix`,
`IdentityMatrix`, promise (fully) mutable results if and only if the
filter in question implies `IsCopyable`.
- In the definitions of `Vector` and `Matrix`, promise mutable results
if and only if the filter in question implies `IsCopyable` and the
vector/matrix that defines the entries is mutable.
- changed the currently available `ConstructingFilter` values such that
they imply `IsCopyable`.
(I assume that these filters can be found as follows.)
```
flags:= List( [ IsVectorObj, IsMatrixObj ], FLAG1_FILTER );;
Filtered( FILTERS, x -> IsRepresentation( x ) and Intersection( flags, TRUES_FLAGS( WITH_IMPS_FLAGS( FLAGS_FILTER( x ) ) ) ) <> [] );
```
- extended the definition of `Vector( v, w )` such that also the case of
`w` in `IsPlistRep` is supported,
and added a method for both arguments in `IsList and IsCyclotomicCollection`
(to be used for example for objects in `IsAlgebraicElement`).
ThomasBreuer
added
kind: enhancement
fingolfin
changed the title
... of vector and matrix objects, and mention that they admit mutable variants Details: - moved the manual section "Basic operations for row/column reductions" above the section "Implementing New Vector and Matrix Objects Types", in order to collect the stuff about implementations at the end of the chapter - added new manual sections for the documentation of `IsGF2VectorRep`, `Is8BitVectorRep`, `IsZmodnZVectorRep`, `IsGF2MatrixRep`, `Is8BitMatrixRep`, `IsZmodnZMatrixRep` - moved the documentation of `IsPlistVectorRep` and `IsPlistMatrixRep` to the new sections - changed some formulations such that `IsPlistMatrixRep` appears just as one instance of `IsRowListMatrix`
wucas
approved these changes
Dec 15, 2022
fingolfin
requested changes
Dec 15, 2022
| ## a matrix object (see <Ref Filt="IsMatrixObj"/>) that behaves like the | ||
| ## list of its rows (see <Ref Filt="IsRowListMatrix"/>). | ||
| ## <A>obj</A> is internally represented as a positional object | ||
| ## (see <Ref Filt="IsPositionalObjectRep"/>) with <M>4</M> entries. |
There was a problem hiding this comment.
As we just discussed on gather.town, I'd prefer to either keep these implementation specifics out of the user-visible documentation, or else to at least qualify them to indicate that these are subject to change and one should not write code exploiting them but rather use official interfaces.
... from the documentation of representations of matrix and vector objects. (This affects documentation added in a previous commit of this pull request as well as documentation that has been available already before.)
ThomasBreuer
force-pushed
the
TB_MatrixObj_mutability
branch
from
02e4480
to
cd5b4a0
Compare
|
@fingolfin I have addressed your request. |
fingolfin
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This addresses issue #5231.)
I hope this proposal makes sense. Comments are welcome.
changed the mutability definition for vector and matrix objects:
ConstructingFiltervalue indicates whether mutable variants are possible at all, as follows: If the filter impliesIsCopyablethen one can create mutable variants, otherwise not.NewVector,ZeroVector,NewMatrix,ZeroMatrix,IdentityMatrix, promise (fully) mutable results if and only if the filter in question impliesIsCopyable.VectorandMatrix, promise mutable results if and only if the filter in question impliesIsCopyableand the vector/matrix that defines the entries is mutable.changed the currently available
ConstructingFiltervalues such that they implyIsCopyable. (I assume that these filters can be found as follows:flags:= List( [ IsVectorObj, IsMatrixObj ], FLAG1_FILTER );; Filtered( FILTERS, x -> IsRepresentation( x ) and Intersection( flags, TRUES_FLAGS( WITH_IMPS_FLAGS( FLAGS_FILTER( x ) ) ) ) <> [] );)extended the definition of
Vector( v, w )such that also the case ofwinIsPlistRepis supported, and added a method for both arguments inIsList and IsCyclotomicCollection(to be used for example for objects inIsAlgebraicElement).