add two tests for trivial cases which cause errors when nilmat is loaded #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh11
added
the
do not merge
|
New release of NilMat 1.3 is published at http://larmor2.nuigalway.ie/~dane/nilmat/ and is now waiting to be picked up and tested. Let's see what will happen. |
|
Tests pass with Nilmat 1.3. This PR needs rebasing to resolve conflicts and may be closed as soon as Nilmat 1.3 will appear in the merged packages archive for the master branch (switch to this archive planned in #1714). |
|
@bh11 would you be able to rebase this, please? |
bh11
removed
the
do not merge
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
==========================================
- Coverage 62.82% 62.82% -0.01%
==========================================
Files 969 969
Lines 295200 295201 +1
Branches 13050 13050
==========================================
- Hits 185453 185447 -6
- Misses 106951 106953 +2
- Partials 2796 2801 +5
|
olexandr-konovalov
approved these changes
Oct 20, 2017
olexandr-konovalov
requested changes
Oct 20, 2017
There was a problem hiding this comment.
The only minor comment is the commit message which has too long first line which then is displayed with a bad line break. What about:
Add two test cases for a trivial matrix group
These tests were broken when NilMat 1.2 was loaded. The problem has been fixed in NilMat 1.3.
Closes #631.
These tests were broken when NilMat 1.2 was loaded. The problem has been fixed in NilMat 1.3.
olexandr-konovalov
approved these changes
Oct 21, 2017
|
@bh11 thanks again! |
olexandr-konovalov
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nilmat (v. 1.2) is loaded, the two added tests cause
Errors. Do not merge before nilmat gets updated. The same error is also triggerred by CRISP automatic tests when nilmat is loaded.This resolves #631.