Fix #397 (Segfault after quitting from a break loop) #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the interpreter runs into an error while reading from a stream and tries to check for a dual semicolon at the end of the statement, the call to GetSymbol() leads to a call to ReadLine on the input stream. With (IsInputTextStream and IsInputTextStringRep) the correct method is selected and called. The crash happens inside the method when trying to access the stream or local variables. This might not be the correct fix yet, but it seems clear that the interpreter state is not right at this point.
|
Looks right to me, and I've tried hammering it in various ways and I can't make anything break. |
olexandr-konovalov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the interpreter runs into an error while reading from a stream and
tries to check for a dual semicolon at the end of the statement, the
call to GetSymbol() leads to a call to ReadLine on the input stream.
With (IsInputTextStream and IsInputTextStringRep) the correct method
is selected and called. The crash happens inside the method when trying
to access the stream or local variables.
This might not be the correct fix yet, but it seems clear that the
interpreter state is not right at this point.
Maybe @stevelinton or @ChrisJefferson can have a look and comment.