make key and attribute values immutable #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid potential problems if the stored key or attribute value is mutable and may be changed accidentally. In most cases, both will be already immutable.
Merged
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid potential problems if the stored key or attribute value is mutable and may be changed accidentally. In most cases, both will be already immutable.
This addresses a problem with mutable keys which showed up in issue #707.
I've decided to make the value immutable as well, to be consistent with ordinary attributes – as far as I can see, neither GAP library nor packages require mutable attributes. If mutable key dependent attributes are needed, it's probably better to add a "mutable" argument, similar to ordinary attributes.
A similar potential problem exists in GAP 4.8 (and probably way back to the origins of
KeyDependentOperation, not sure if this needs to be fixed as well. The fix would be slightly different because of the changes in #514.