Add FiltersObj and FiltersType functions #925
Conversation
markuspf
force-pushed
the
add-filtersobj
branch
from
7a744fa
to
c06046c
Compare
Current coverage is 48.82% (diff: 0.00%)@@ master #925 diff @@
==========================================
Files 424 424
Lines 222143 222145 +2
Methods 3428 3428
Messages 0 0
Branches 0 0
==========================================
- Hits 108589 108470 -119
- Misses 113554 113675 +121
Partials 0 0
|
| ## | ||
| #Y Copyright (C) 1997, Lehrstuhl D für Mathematik, RWTH Aachen, Germany | ||
| #Y (C) 1998 School Math and Comp. Sci., University of St Andrews, Scotland | ||
| #Y Copyright (C) 2002 The GAP Group |
There was a problem hiding this comment.
This reminds me: We should revise our copyright headers. In any case, it doesn't make sense to mark something as Copyright 2002 that is added in 2016.
Of course one can now debate whether this is the copyright of the file, or of all of GAP; but even in that latter case, it should be "2002-2016".
| #Y Copyright (C) 2002 The GAP Group | ||
| ## | ||
| ## This file implements some additional functions relating to types and | ||
| ## families. |
There was a problem hiding this comment.
Nitpick: this .gd file does not "implement" anything; rather, it contains declarations.
| ## | ||
| #M FiltersObj( <object> ) | ||
| ## | ||
| ## Return list of filters set in the type |
| @@ -13,6 +13,24 @@ | |||
|
|
|||
| ############################################################################# | |||
| ## | |||
| #M FiltersType( <type> ) | |||
| ## | |||
| ## Return list of filters set in the type | |||
There was a problem hiding this comment.
Perhaps this is just me, but that sounds weird to me... I'd think it should be either "Return list of filters set in .", if type is meant to refer to the name of the argument, or "Return list of filters sets in the given type." if type is meant to refer to the fact that the argument is supposed to be a type object.
| obj -> FiltersType(TypeObj(obj))); | ||
|
|
||
| ############################################################################# | ||
| ## | ||
| #M NamesFilterShort( flags, max ) |
There was a problem hiding this comment.
All in all, this PR looks fine to me. Better introspection features certainly seems like a useful addition to me, be it to debug the system, or to learn.
* FiltersType returns the list of filters set in the passed type * FiltersObj does the same for the passed object
markuspf
force-pushed
the
add-filtersobj
branch
from
c06046c
to
f958b4b
Compare
|
Updated to accommodate for @fingolfin's comments. |
olexandr-konovalov
added
the
release notes: added
The FiltersType and FiltersObj functions return the list of filters set in a type (of an object).