This repository has been archived by the owner on Apr 25, 2018. It is now read-only.
Fix mountable test async failures #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const node = document.createElement(`div`) | ||
|
|
||
| // ensure that callback does not get called | ||
| const callback = () => assert.notOk(true) | ||
| const callback = sinon.spy() |
There was a problem hiding this comment.
Nice catch! Though you don't need sinon here. If you use done as the callback, the test will fail if the callback is not called.
There was a problem hiding this comment.
Thanks! The trick is we don't want the callback to be called, but AFAICT, mocha expects done to be called with or without an error. I initially implemented as const callback = done(new Error('...')) but was seeing errors due to done not being called.
There was a problem hiding this comment.
Ha, yep. I did the same.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the "does not emit" test cases for
mountablefail, they fail after the test function returns, resulting in no stack trace being reported. I stumbled on this while trying to quickly break a test to verify the karma sourcemaps PR was working as expected.I updated the broken cases to use
done. I know some don't like usingsetTimeout, but AFAIK, it is the most reasonable way to schedule verification after the possible event is dispatched.I also updated a couple of test labels for unmount to use "unmount" instead of "mount".