This repository has been archived by the owner on Apr 25, 2018. It is now read-only.
Clarify types and enable flow for node proxies #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @garbles,
I was happy to see the addition of
VirtualText
, noticed your commit about disabling flow inNodeProxy
, and decided to take a look at the flow issue. I am wondering whether you will want to keep a single proxy type, but I ended up thinking we should have separate proxy types for element and text because they are simply different things.Here's a summary of my changes:
NodeProxy
intoElementProxy
andTextProxy
nodeValue
rather thantextContent
because it is more directTextProxy
(just 2 test cases)VirtualNode
toVirtualElement
for clarity because both text and elements are nodes in the DOM.VirtualElement
toVirtualNode
intypes.js
NodeProxyDecorator
toElementProxyDecorator
intypes.js
If you are open to these changes and how I wrote the
TextProxy
tests, I can also write tests forElementProxy
either before or after landing this.What do you think?