This repository has been archived by the owner on May 10, 2023. It is now read-only.
The "Vehicle.trip_timeout" should belong to "Trip" and be named "timeout". #48
Assignees
Labels
approved
This issue is currently approved but waiting to be solved.
enhancement
New feature or request
programming
This issue is related with source code implementation.
Milestone
Comments
garciparedes
added
enhancement
garciparedes
added a commit
that referenced
this issue
Oct 25, 2019
* Now "timeout" and "trip_timeout" has "MAX_FLOAT" as default.
garciparedes
added a commit
that referenced
this issue
Oct 25, 2019
garciparedes
added a commit
that referenced
this issue
Oct 25, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is your feature request related to a problem? Please describe.
Now the timeout term is a bit confusing because it has two meaning around
jinete. On the one hand,timeoutmeans the offset to be added to theearliestlower threshold to reach thelatestupper threshold. On the other hand, it means the maxRoute/Tripallowed duration.Describe the solution you'd like
The solution I propose is to split this concepts into two. On the one hand, it doesn't make sense to use the
timeoutterm to define the "range" length betweenearliestandlatestso it can be replaced byrangeif the input parameters areearliestandlatest. On the other hand, it makes sense to be referred to the maxRoute/Tripallowed duration bytimeout.Additional context
This issue is strictly related with #49.
The text was updated successfully, but these errors were encountered: