Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Testing for 'test' in NODE_ENV #6

Open
singlow opened this issue Jan 9, 2017 · 1 comment
Open

Testing for 'test' in NODE_ENV #6

singlow opened this issue Jan 9, 2017 · 1 comment

Comments

@singlow
Copy link

singlow commented Jan 9, 2017

web-bff/src/logger.js

Line 4 in 15d28ec

const isTest = process.env.NODE_ENV = 'test'; 

const isTest = process.env.NODE_ENV = 'test';

Is this doing anything? Should that be:

const isTest = process.env.NODE_ENV === 'test';
@johncmckim
Copy link
Member

Good find! That's a bug.

singlow added a commit to singlow/web-bff that referenced this issue Jan 10, 2017
@singlow
Use equality operator instead of assignment
1e0c492 
Fixes issue garden-aid#6
@singlow singlow mentioned this issue Jan 10, 2017
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@singlow @johncmckim