Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI returns exit code 1 when help or --version args passed #626

Closed
eysi09 opened this issue Mar 13, 2019 · 4 comments
Closed

CLI returns exit code 1 when help or --version args passed #626

eysi09 opened this issue Mar 13, 2019 · 4 comments
Assignees
Labels
bug priority:medium Medium priority issue or feature

Comments

@eysi09
Copy link
Collaborator

eysi09 commented Mar 13, 2019

The following commands return exit code 1 instead of 0:

garden --version
garden help

Note that garden --help returns 0 as expected and garden version returns 0 if in a project directory but fails with Not a project directory (or any of the parent directories): ... otherwise.

@eysi09 eysi09 added bug priority:low Low priority issue or feature labels Mar 13, 2019
@eysi09 eysi09 added priority:medium Medium priority issue or feature and removed priority:low Low priority issue or feature labels Mar 25, 2019
@eysi09 eysi09 self-assigned this Mar 25, 2019
@eysi09
Copy link
Collaborator Author

eysi09 commented Mar 25, 2019

We need to fix this for Garden to work properly in CI.

@edvald
Copy link
Collaborator

edvald commented Mar 25, 2019

Hmm, why is that?

@eysi09
Copy link
Collaborator Author

eysi09 commented Mar 25, 2019

Well, this was kind of poorly phrased, Garden works fine in CI regardless.

The above was more of a note to self since I'm trying Garden on different CI systems and like to verify that it's properly installed on the agent by running garden --version. However, that causes the CI job to fail because it returns exit code 1.

eysi09 added a commit that referenced this issue Mar 26, 2019
...also changed LoggerType from enum to union type
eysi09 added a commit that referenced this issue Mar 27, 2019
...also changed LoggerType from enum to union type
eysi09 added a commit that referenced this issue Mar 27, 2019
...also changed LoggerType from enum to union type
eysi09 added a commit that referenced this issue Mar 27, 2019
...also changed LoggerType from enum to union type
eysi09 added a commit that referenced this issue Mar 27, 2019
fix: ensure CLI returns correct exit code (#626)
@eysi09
Copy link
Collaborator Author

eysi09 commented Apr 15, 2019

Closed in #669

@eysi09 eysi09 closed this as completed Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug priority:medium Medium priority issue or feature
Projects
None yet
Development

No branches or pull requests

2 participants