Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreachable code when kubectl diff errors #786

Closed
eysi09 opened this issue May 19, 2019 · 0 comments
Closed

Unreachable code when kubectl diff errors #786

eysi09 opened this issue May 19, 2019 · 0 comments
Labels
bug priority:low Low priority issue or feature

Comments

@eysi09
Copy link
Collaborator

eysi09 commented May 19, 2019

The detail key is never defined on the error object in the following catch block:

https://github.com/garden-io/garden/blob/master/garden-service/src/plugins/kubernetes/status.ts#L462-L485

This is because kubectl.exec calls execa but the assumption is probably that it calls our own spawn method which does indeed add the detail key to the error object.

Flagging this as a bug since it will result in an imprecise error message for the user.
@eysi09 eysi09 added bug priority:low Low priority issue or feature labels May 19, 2019
edvald added a commit that referenced this issue Jun 17, 2019
@edvald
fix(k8s): unreachable code when kubectl diff errors
be1174e 
Closes #786
thsig pushed a commit that referenced this issue Jun 20, 2019
@edvald @thsig
fix(k8s): unreachable code when kubectl diff errors
29ae098 
Closes #786
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug priority:low Low priority issue or feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eysi09