feat(k8s): add Helm module inheritance via the base field
#482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
force-pushed
the
helm-inheritance
branch
2 times, most recently
from
9c6d2f7
to
81701bb
Compare
thsig
approved these changes
Jan 25, 2019
examples/vote-helm/README.md
Outdated
| @@ -1,13 +1,19 @@ | |||
| # Voting example project with Helm charts | |||
|
|
|||
| This is a clone of the [vote example project](../vote/README.md), modified to use Helm charts to describe | |||
| Kubernetes resources, instead of the `container` module type. | |||
| Kubernetes resources, instead of the simplified `container` module type. | |||
There was a problem hiding this comment.
"simplified" -> "simpler" / "relatively simpler"?
| helper function) in order to enforce correct usage. We recommend enforcing constraints like that, so that mistakes | ||
| can be caught quickly. | ||
|
|
||
| The `result` module also use the same base chart, but sets different values and metadata: |
edvald
force-pushed
the
helm-inheritance
branch
from
81701bb
to
14875ab
Compare
edvald
force-pushed
the
helm-inheritance
branch
from
14875ab
to
8a7a7e5
Compare
This was referenced May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the updated
vote-helmexample, and the added section in the Helm guide for details: https://github.com/garden-io/garden/blob/8a2c5aed81ac08f13d57f270360be674d110917d/docs/using-garden/using-helm-charts.md