fix: use abs target paths in HR copy commands #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsig
force-pushed
the
hot-reload-copy-fix
branch
from
f04e188
to
19e40cc
Compare
edvald
reviewed
Mar 12, 2019
edvald
reviewed
Mar 12, 2019
edvald
requested changes
Mar 12, 2019
thsig
force-pushed
the
hot-reload-copy-fix
branch
4 times, most recently
from
d5f7ef8
to
875bbc5
Compare
This fixes various issues with hot reload sync configuration and simplifies the internal logic. One issue resolved by this change is that Dockerfiles with WORKDIRs nested under one of the sync targets no longer cause problems with hot reloading.
thsig
force-pushed
the
hot-reload-copy-fix
branch
from
875bbc5
to
94619f6
Compare
edvald
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various issues with hot reload sync configuration and simplifies the internal logic.
One issue resolved by this change is that
Dockerfiles withWORKDIRs nested under one of the sync targets no longer cause problems with hot reloading.