Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli updates #821

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Cli updates #821

merged 3 commits into from
Jun 11, 2019

Conversation

eysi09
Copy link
Collaborator

@eysi09 eysi09 commented Jun 6, 2019

This PR contains a handful of small CLI improvements and refactors:

  • Rename the --loglevel flag to --log-level for consistency.
  • Remove Global Options from CLI help output and use a dedicated command instead.
  • Add log header to commands, along with necessary refactors.

Closes #668.

edvald
edvald requested changes Jun 10, 2019
View reviewed changes
Copy link
Collaborator

@edvald edvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks, otherwise 👍

docs/reference/commands.md Outdated Show resolved Hide resolved
garden-service/src/cli/helpers.ts Outdated Show resolved Hide resolved
garden-service/src/commands/exec.ts Show resolved Hide resolved
@eysi09
improvement(cli): rename --loglevel to --log-level + refactor log init
de5e78a 
BREAKING CHANGE:

The --loglevel CLI option is now called --log-level
@eysi09
feat(cli): add a dedicated options command
8dd5300 
Global options are now no longer printed with the CLI help output.
@eysi09
refactor(cli): add header log to commands
51c7efe
@eysi09 eysi09 merged commit 62badf0 into master Jun 11, 2019
@eysi09 eysi09 deleted the cli-updates branch June 11, 2019 13:42
@qsays qsays mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edvald edvald edvald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up CLI flags
2 participants
@eysi09 @edvald