Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

enable gardenctl logs all to download all logs to current dir/logs folder #437

Merged
merged 2 commits into from
Nov 17, 2020

Conversation

neo-liang-sap
Copy link
Contributor

@neo-liang-sap neo-liang-sap commented Nov 11, 2020

What this PR does / why we need it:
enable gardenctl logs all to download all logs to current dir/logs folder
Which issue(s) this PR fixes:
Fixes #345

Special notes for your reviewer:
1 - --loki flag is not working for now, tracked in #433
2 - some logs in garden namespace could not be get, tracked in #426
3 - for now , supporting get following logs: APIServer/Scheduler/ControllerManager/etcd/AddonManager/VpnShoot/Dashboard/Prometheus/Gardenlet/Autoscaler
Release note:

enable `gardenctl logs all` to download all logs to current dir/logs folder

@neo-liang-sap neo-liang-sap requested a review from a team as a code owner November 11, 2020 01:36
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 11, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 11, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 11, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 11, 2020
@neo-liang-sap
Copy link
Contributor Author

will rebase this PR after #404 merge

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 17, 2020
@neo-liang-sap
Copy link
Contributor Author

fixed conflict with current master branch

@neo-liang-sap
Copy link
Contributor Author

neo-liang-sap commented Nov 17, 2020

as discussed in planning mtg i will merge this one

@neo-liang-sap neo-liang-sap merged commit 3f8a1c7 into gardener-attic:master Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add gardenctl logs all target
4 participants