-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh/stable worker hash #4237
Merged
Merged
Enh/stable worker hash #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
API change with impact on API users
needs/second-opinion
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jun 21, 2021
31 tasks
rfranzke
reviewed
Jun 23, 2021
Worker pools with `CRI==nil` use `docker` as their container runtime. Changing to an explicit configuration of `docker` should not trigger a node rollout. Therefore, we need to keep the Worker hash stable by excluding the `cri.name` property from hash calculation in this case. Co-authored-by: Max Becker <max.becker@sap.com>
BeckerMax
force-pushed
the
enh/stable-worker-hash
branch
from
June 24, 2021 12:06
c0ffaa9
to
ae14f28
Compare
vpnachev
suggested changes
Jun 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small improvement to avoid one nested if block.
vpnachev
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/squash
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Exclude cri.name `docker` from worker hash calculation Worker pools with `CRI==nil` use `docker` as their container runtime. Changing to an explicit configuration of `docker` should not trigger a node rollout. Therefore, we need to keep the Worker hash stable by excluding the `cri.name` property from hash calculation in this case. Co-authored-by: Max Becker <max.becker@sap.com> * Merge two if-blocks into single 'and' condition Co-authored-by: Max Becker <max.becker@sap.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Exclude cri.name `docker` from worker hash calculation Worker pools with `CRI==nil` use `docker` as their container runtime. Changing to an explicit configuration of `docker` should not trigger a node rollout. Therefore, we need to keep the Worker hash stable by excluding the `cri.name` property from hash calculation in this case. Co-authored-by: Max Becker <max.becker@sap.com> * Merge two if-blocks into single 'and' condition Co-authored-by: Max Becker <max.becker@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/api-change
API change with impact on API users
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Exclude cri.name
docker
from worker hash calculationWorker pools with
CRI==nil
usedocker
as their container runtime. Changing to an explicit configuration ofdocker
should not trigger a node rollout. Therefore, we need to keep the Worker hash stable by excluding thecri.name
property from hash calculation in this case.Part of #4110
Special notes for your reviewer:
Marked as draft as it depends on #4218 .
Release note:
Do not trigger a node rollout when switching from `CRI.Name==nil` to `CRI.Name==docker`.
cc @BeckerMax