Enh/stable worker hash #4237
Merged
Enh/stable worker hash #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
kind/api-change
31 tasks
rfranzke
reviewed
Jun 23, 2021
Worker pools with `CRI==nil` use `docker` as their container runtime. Changing to an explicit configuration of `docker` should not trigger a node rollout. Therefore, we need to keep the Worker hash stable by excluding the `cri.name` property from hash calculation in this case. Co-authored-by: Max Becker <max.becker@sap.com>
BeckerMax
force-pushed
the
enh/stable-worker-hash
branch
from
c0ffaa9
to
ae14f28
Compare
vpnachev
suggested changes
Jun 24, 2021
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Apr 21, 2022
* Exclude cri.name `docker` from worker hash calculation Worker pools with `CRI==nil` use `docker` as their container runtime. Changing to an explicit configuration of `docker` should not trigger a node rollout. Therefore, we need to keep the Worker hash stable by excluding the `cri.name` property from hash calculation in this case. Co-authored-by: Max Becker <max.becker@sap.com> * Merge two if-blocks into single 'and' condition Co-authored-by: Max Becker <max.becker@sap.com>
krgostev
pushed a commit
to krgostev/gardener
that referenced
this pull request
Jul 5, 2022
* Exclude cri.name `docker` from worker hash calculation Worker pools with `CRI==nil` use `docker` as their container runtime. Changing to an explicit configuration of `docker` should not trigger a node rollout. Therefore, we need to keep the Worker hash stable by excluding the `cri.name` property from hash calculation in this case. Co-authored-by: Max Becker <max.becker@sap.com> * Merge two if-blocks into single 'and' condition Co-authored-by: Max Becker <max.becker@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Exclude cri.name
dockerfrom worker hash calculationWorker pools with
CRI==nilusedockeras their container runtime. Changing to an explicit configuration ofdockershould not trigger a node rollout. Therefore, we need to keep the Worker hash stable by excluding thecri.nameproperty from hash calculation in this case.Part of #4110
Special notes for your reviewer:
Marked as draft as it depends on #4218 .
Release note:
Do not trigger a node rollout when switching from `CRI.Name==nil` to `CRI.Name==docker`.cc @BeckerMax