Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make docker container runtime a first-class citizen #1038

Closed
Tracked by #4110
BeckerMax opened this issue Jun 22, 2021 · 0 comments · Fixed by #1059
Closed
Tracked by #4110

Make docker container runtime a first-class citizen #1038

BeckerMax opened this issue Jun 22, 2021 · 0 comments · Fixed by #1059
Labels
component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension

Comments

@BeckerMax
Copy link
Contributor

What would you like to be added:

  • Read list of supported runtimes from CloudProfile only, don't add docker to the list of available container runtimes for a MachineImageVersion
  • When docker is selected, set cri.name=docker explicitly, don't leave cri=nil
  • This concerns both aspects: adding a new cluster and/or worker pool as well as modifying an existing worker pool
  • Notice to the release notes that open-source users have to adapt their CloudProfile to explicitly add docker to all MachineImageVersions which support it.

Why is this needed:
In the context of deprecating the in-tree dockershim, we're making a few changes to g/g, which will result in shoots with k8s version >=1.22 getting containerd as container runtime when cri=nil:

Note
Prerequisites for this change are

  • As a user, I don't want a node rollout to happen when my configuration change is essentially a no-op, such that I don't suffer from unnecessary downtime (cases: explicitly specifying docker when previously created with docker as implicit default): Enh/stable worker hash gardener#4237
  • Adapting the CloudProfile as mentioned above before deploying

This is a prerequisite for releasing a g/g version which supports k8s 1.22 (earliest in August).

cc @voelzmo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dashboard Gardener Dashboard kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant