Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support full strategic merge patch #25

Closed
amshuman-kr opened this issue Oct 30, 2020 · 0 comments · Fixed by #59
Closed

Support full strategic merge patch #25

amshuman-kr opened this issue Oct 30, 2020 · 0 comments · Fixed by #59
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) lifecycle/rotten Nobody worked on this for 12 months (final aging stage) status/closed Issue is closed (either delivered or triaged)

Comments

@amshuman-kr
Copy link
Collaborator

What would you like to be added:
If there is a conflict between the scheduling criteria (potentially more than one) being injected and what is already present in the target pod spec/template, merge done by kupid is currently ad hoc.

It is desirable to support full strategic merge patch in such a cases.

Why is this needed:
Consistency with Kubernetes best-practicies.
@amshuman-kr amshuman-kr added kind/enhancement Enhancement, improvement, extension lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) area/control-plane Control plane related labels Oct 30, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 22, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Mar 24, 2022
@shreyas-s-rao shreyas-s-rao mentioned this issue Jun 5, 2023
Merged
5 tasks
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) lifecycle/rotten Nobody worked on this for 12 months (final aging stage) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix merge logic for node affinities shreyas-s-rao/kupid
2 participants
@amshuman-kr @gardener-robot