Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Terraformer v2 #58

Merged
merged 14 commits into from
Nov 23, 2020
Merged

[master] Terraformer v2 #58

merged 14 commits into from
Nov 23, 2020

Conversation

timebertt
Copy link
Member

@timebertt timebertt commented Nov 23, 2020

What this PR does / why we need it:

The terraformer v2 rewrite is finished and all open tasks have been completed.
So this PR merges terraformer-v2 onto master (without any changes, only resolving merge conflicts).

Which issue(s) this PR fixes:
Fixes #40

Special notes for your reviewer:

Release note:

Terraformer version `v2` now requires to pass in ConfigMap and Secret names via command line flags instead of environment variables and the base command of the docker image has changed to `/terraformer`. Please see the [examples](https://github.com/gardener/terraformer/tree/master/example) for more details.
If your provider extension is deploying terraformer Pods via gardener's [terraformer library](https://github.com/gardener/gardener/tree/master/extensions/pkg/terraformer), please make sure, that you use at least `gardener/gardener@v1.12.0` and set `terraformer.UseV2(true)` in order to deploy a PodSpec, that is compatible with terraformer `v2`.
Terraformer was rewritten in go and now watches the terraform state file in order to continuously update the state ConfigMap to not lose any relevant infrastructure state.
You can use `make start-dev-container` to start a docker container which can run terraformer and tests in an isolated environment for development and testing. Also `make start` will run terraformer commands in such a development container.

@timebertt timebertt requested a review from a team as a code owner November 23, 2020 11:33
@gardener-robot gardener-robot added the needs/review Needs review label Nov 23, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 23, 2020
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 23, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 23, 2020
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot removed the needs/review Needs review label Nov 23, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 23, 2020
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Nov 23, 2020
@timebertt
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Nov 23, 2020

Testrun: e2e-gwgvj
Workflow: e2e-gwgvj-wf
Phase: Succeeded

+--------------+--------------+-----------+----------+
|     NAME     |     STEP     |   PHASE   | DURATION |
+--------------+--------------+-----------+----------+
| pod-e2e-test | pod-e2e-test | Succeeded | 2m34s    |
+--------------+--------------+-----------+----------+

@timebertt timebertt merged commit 7db2398 into master Nov 23, 2020
@timebertt timebertt deleted the terraformer-v2 branch November 23, 2020 11:56
@timebertt timebertt restored the terraformer-v2 branch November 23, 2020 11:57
@timebertt timebertt deleted the terraformer-v2 branch November 23, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/test Test needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang wrapper for terraform process
6 participants