Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#47) Fixed __builtins__.__dict__ erroneous behavior #48

Closed
wants to merge 1 commit into from
Closed

(#47) Fixed __builtins__.__dict__ erroneous behavior #48

wants to merge 1 commit into from

Conversation

fiatjaf
Copy link

@fiatjaf fiatjaf commented Sep 20, 2013

No description provided.

@gareth-rees
Copy link
Owner

What problem does this solve?

@fiatjaf
Copy link
Author

fiatjaf commented Sep 21, 2013

I created an issue: #47
It's mostly because I'm trying to use minipy as a module, but you don't need to bother.

@gareth-rees
Copy link
Owner

Thanks for reporting the issue. Your fix looks good, although on reflection I think dir(__builtin__) is probably clearer than __builtin__.__dict__. But the fix needs a test case too, so I'm going to close this pull request and fix issue #47 separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fiatjaf @gareth-rees