allow multiple roles in a single node #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locate multiple services on the same node is a common practice. But the current implementation of the
serf-master
module does not support it. In order to allow this use-case, the 'role' tag could handle a list of roles.So the event handler must extract that list of roles and then the proxy would be able to execute a collection of handlers instead of just one.
i'm not really comfortable with python, so don't hesitate to comment the proposed implementation :)