Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow multiple roles in a single node #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kpacha
Copy link

@kpacha kpacha commented May 30, 2015

Locate multiple services on the same node is a common practice. But the current implementation of the serf-master module does not support it. In order to allow this use-case, the 'role' tag could handle a list of roles.

serf agent -tag role="web:db" -event-handler /opt/your/script.py

So the event handler must extract that list of roles and then the proxy would be able to execute a collection of handlers instead of just one.

i'm not really comfortable with python, so don't hesitate to comment the proposed implementation :)

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 28beb1e on kpacha:allow_multiple_roles into 2990899 on garethr:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 455c419 on kpacha:allow_multiple_roles into 2990899 on garethr:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 99.19% when pulling 455c419 on kpacha:allow_multiple_roles into 2990899 on garethr:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants