Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Donations Modal on Home Page #23

Closed
garg3133 opened this issue Dec 4, 2020 · 22 comments
Closed

Enhance Donations Modal on Home Page #23

garg3133 opened this issue Dec 4, 2020 · 22 comments

Comments

@garg3133
Copy link
Owner

garg3133 commented Dec 4, 2020

Details on the issue:
On clicking the "Donate" button on the top navigation bar, a modal/pop-up appears which has a very basic design and does not look good. It would be better if the design of the modal could be improved (using colours as per the theme of the site).

Below is the screenshot of the modal.

image

Working on this issue requires an intermediate knowledge of HTML and CSS.

For any further doubts and queries, feel free to join the community and ask there: https://discord.gg/Ek9q45ZjAv

@Aarti002
Copy link

Aarti002 commented Dec 5, 2020

hello sir i'm from 2nd year iiitdmj can i work on this issue?

@garg3133
Copy link
Owner Author

garg3133 commented Dec 5, 2020

Sure @Aarti002, go ahead! Assigning you the issue.

@garg3133
Copy link
Owner Author

@Aarti002 Any progress?

@Isha77agarwal
Copy link

I want to work on this issue, I have a good knowledge of CSS and HTML.

@garg3133
Copy link
Owner Author

Yes @Isha77agarwal, you can work on this issue.

@Isha77agarwal
Copy link

@garg3133 I am having some issues with migration, Can you help?

@garg3133
Copy link
Owner Author

Yeah sure, what issues are you facing?

@Isha77agarwal
Copy link

File "C:\Users\isha7\AppData\Local\Programs\Python\Python37\lib\site-packages\decouple.py", line 68, in get
raise UndefinedValueError('{} not found. Declare it as envvar or define a default value.'.format(option))
decouple.UndefinedValueError: EMAIL_HOST_USER not found. Declare it as envvar or define a default value.

image

@garg3133
Copy link
Owner Author

Have you created .env file in JagratiWebApp directory as mentioned in README?

Also, for windows, don't use source while activating the environment.

@Isha77agarwal
Copy link

Yes, I created that file.
I tried without source, it is also not working

@garg3133
Copy link
Owner Author

Try moving the .env file to JagratiWebApp/Jagrati/settings.

@garg3133
Copy link
Owner Author

Also, can you please share the screenshot of your .env file?

@harikishantk
Copy link

I would like to contribute to this issue, May I? I'm SWOC 2021 participant, is this issue comes under SWOC? If so, kindly label this issue under SWOC.

@garg3133
Copy link
Owner Author

Yeah sure @harikishantk, you can contribute to this. I'll add the label before the coding period starts.

@Abhir-24
Copy link

Can I work on this issue under SWOC ?

@garg3133
Copy link
Owner Author

@Abhir-24 For SWOC, @harikishantk asked first so I'll assign the issue to him when SWOC starts. You may look at other issues if any of them interests you.

@tushhr
Copy link
Collaborator

tushhr commented Dec 31, 2020

File "C:\Users\isha7\AppData\Local\Programs\Python\Python37\lib\site-packages\decouple.py", line 68, in get
raise UndefinedValueError('{} not found. Declare it as envvar or define a default value.'.format(option))
decouple.UndefinedValueError: EMAIL_HOST_USER not found. Declare it as envvar or define a default value.

@Isha77agarwal as you are setting up this project in windows from Command Prompt,
use env\Scripts\activate, instead of env/Scripts/activate.

According to the Documentation:

"Once a virtual environment has been created, it can be “activated” using a script in the virtual environment’s binary directory. The invocation of the script is platform-specific ( must be replaced by the path of the directory containing the virtual environment)

Platform Shell Command to activate virtual environment
POSIX bash/zsh $ source /bin/activate
  fish $ source /bin/activate.fish
  csh/tcsh $ source /bin/activate.csh
  PowerShell Core $ /bin/Activate.ps1
Windows cmd.exe C:> \Scripts\activate.bat
  PowerShell PS C:> \Scripts\Activate.ps1

@garg3133 garg3133 removed the SWOC 2021 label Mar 1, 2021
amanchande pushed a commit to amanchande/JagratiWebApp that referenced this issue Mar 3, 2021
@tushhr
Copy link
Collaborator

tushhr commented Mar 9, 2021

Hey, @harikishantk are you still working on this?

@harikishantk
Copy link

Hey, @harikishantk are you still working on this?

Yes I'm working on it, under GSSoC 21.

@tushhr tushhr added the gssoc21 label Mar 9, 2021
@garg3133
Copy link
Owner Author

@harikishantk Now I'm thinking of removing the second column in the donations modal and keeping two rows instead. The top row should have the bank details (with title and value of each field inline) and in the second column, we can have a small message like this:

OR (in the center or as it would look good)
Donate books, clothes, stationery items or anything else which might be useful to the kids. Contact:
...
...
...
for making your donations.

This was referenced Mar 30, 2021
@Jagrati-Bot
Copy link
Collaborator

Jagrati-Bot commented Apr 14, 2021

Hello @harikishantk, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

Thanks for your contributions, and hope to see you again soon!

@garg3133
Copy link
Owner Author

Resolved in #208.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants