Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send RGB color by cmd #12

Closed
sfabrizio opened this issue Nov 25, 2020 · 1 comment · Fixed by #14
Closed

Send RGB color by cmd #12

sfabrizio opened this issue Nov 25, 2020 · 1 comment · Fixed by #14
Assignees
@sfabrizio
Labels
enhancement New feature or request

Comments

@sfabrizio
Copy link
Collaborator

New cmd for send just RGB color format and the strip will fill with it.

@garhul Are you okay if I add this feature?

I saw that we have a cmd like this but for set HSL called 'set', so it will be very similar code to it and I will call it 'setRgb'
sfabrizio added a commit that referenced this issue Nov 25, 2020
@sfabrizio
[ADD] cmd: setRgb #12
d9c6a36
@sfabrizio sfabrizio added the enhancement New feature or request label Nov 25, 2020
@sfabrizio sfabrizio self-assigned this Nov 25, 2020
@sfabrizio
Copy link
Collaborator Author

I was thinking that I would be able to control the brightness with 'br' cmd.. but that only works for the effects I found out.. So I'm moving this cmd to Rgbw format instead. So we can send brightness as well.

@sfabrizio sfabrizio mentioned this issue Nov 26, 2020
Closed
sfabrizio added a commit that referenced this issue Nov 28, 2020
@sfabrizio
[MOD] cmd: setRgb #12
6d23843 
     - change to use fillRgb method
     - improved data types
     - add printf
sfabrizio added a commit that referenced this issue Nov 28, 2020
@sfabrizio
[ADD] readme: setRgb in cmd section #12
36c52cd
@sfabrizio sfabrizio linked a pull request Nov 28, 2020 that will close this issue
Feature/cmd setRgb #14
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfabrizio sfabrizio

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/cmd setRgb garhul/aurora
1 participant
@sfabrizio