Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_event_sources fails on SNS and S3 event sources #33

Merged
merged 2 commits into from
Aug 31, 2015

Conversation

ryansb
Copy link
Contributor

@ryansb ryansb commented Aug 22, 2015

Per #32, add an update method for event sources that don't have them.

Per garnaat#32 , adding an update method
for event sources that don't have them.
And, for debug, print the full response for error cases.
@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 0cd86a0 on ryansb:develop into a5cf44b on garnaat:develop.

@garnaat
Copy link
Owner

garnaat commented Aug 30, 2015

I guess they must have changed this. Did the old version stop working for you?

@ryansb
Copy link
Contributor Author

ryansb commented Aug 31, 2015

It didn't, but according to the docs it's a deprecated call, so I thought it'd be good to update it.

The first patch is just for the "update" call on SNS/S3 resources.

garnaat added a commit that referenced this pull request Aug 31, 2015
`update_event_sources` fails on SNS and S3 event sources
@garnaat garnaat merged commit f162ba4 into garnaat:develop Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants