Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix permission problem with local bind mount (#1466) #1467

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

tkrah
Copy link
Contributor

@tkrah tkrah commented Mar 24, 2023

npm run sanity-test-docker
npm run smoke-test-docker

both are able to run now without permission problems.

@tkrah
Copy link
Contributor Author

tkrah commented Mar 24, 2023

I did not catch that problem initially, because I am already running the backstopjs container with my own user via "--user" command because root owned where a mess ;).
@garris I am not that proficient with all those docker shortcuts you may have created - please have a look if some other command may need that user arg too.

Windows users may need to customize the template and switch to "--user %USERNAME%" - that may be something for you @garris to integrate if you want to ;).

Copy link
Owner

@garris garris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @tkrah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants